Vanilla cookie consent implementation
Closes: #3 (closed)
Migrate to the vanilla-cookieconsent npm package for the cookie consent plugin, and remove local copies of plugin implementation sources. Upgrade to version 2.9.8 to set RFC compliant cookies, fixing broken authentication.
Merge request reports
Activity
requested review from @marko_kuder
assigned to @spela_dragan
116 117 dest: 'public/css/dgu-recline-pack.min.css' 117 118 }, 118 119 cookie: { 119 src: 'src/css/cookieconsent.css', 120 dest: 'public/css/cookieconsent.css', 121 }, 122 cookieOPSI : { 123 src: 'src/css/cookieconsent-opsi.css', 124 dest: 'public/css/cookieconsent-opsi.css', 120 src: [ 121 'src/sass/node_modules/vanilla-cookieconsent/src/cookieconsent.css', 122 'src/css/cookieconsent-opsi.css' 123 ], 124 dest: 'public/css/vanilla-cookieconsent.css', -
The src/css/cookieconsent-opsi.css looks quite large - does it already contain everything from the original cookieconsent.css? Is the merging with the vanilla one here even needed then? It would be best if the -opsi.css would contain only the needed changes IF there is not too many of them, so that the merge would make more sense. Also, src/css/vanilla-cookie.css can probably be deleted? It is the same as src/css/cookieconsent-opsi.css
It looks like src/css/cookieconsent-opsi.css is an older version of vanilla-cookie.css with some modifications so I removed parts that were the same and left the ones that changed the color scheme and a few other minor changes. I also removed the src/css/vanilla-cookie.css.
Well, you were faster than me, but I will leave this comment here anyhow.