Skip to content
Snippets Groups Projects

Fix dataset package download

Merged Špela Dragan requested to merge fix-dataset-download into drupal-to-ckan
1 unresolved thread

Closes #8 (closed)

Edited by Špela Dragan

Merge request reports

Merge request pipeline #43571 passed

Merge request pipeline passed for 7a64a008

Deployed to assets/fix-da‎taset-download‎ 1 year ago

Merged by Marko KuderMarko Kuder 1 year ago (Jun 21, 2023 1:31pm UTC)

Loading

Pipeline #43578 passed

Pipeline passed for 7a64a008 on drupal-to-ckan

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • It seems pops-test.xlab.si does not have this problem. It does duplicate the input field in the templates, but somehow it does not result in an array in the final state. @spela_dragan Can you please check the differences between the two deployments if there was some change in ckanext-dgu? I could hypothesize that perhaps it is also linked to SOLR, but the repo should be checked first.

    • I didn't find exactly the function where both form fields are joined into an array, but in this line request.POST contains both fields, and in data_dict they are joined.

      I would guess that there are some differences between python 2.7.5 (used on pops-test) and python 2.7.18, used in vagrant deploy.

      I added a line in JS, that overwrites the value of form field url_type, containing 'upload' to 'upload'. So after another "save" of affected datasets, the issue is gone.

    • Please register or sign in to reply
  • Špela Dragan added 1 commit

    added 1 commit

    • fefd4fe0 - Fix dataset package download

    Compare with previous version

  • Marko Kuder added 2 commits

    added 2 commits

    • 637eab35 - 1 commit from branch drupal-to-ckan
    • 8ab96afc - Fix dataset package download

    Compare with previous version

  • Špela Dragan added 1 commit

    added 1 commit

    • b95c3eff - Fix dataset package download

    Compare with previous version

  • Špela Dragan added 1 commit

    added 1 commit

    • 7a64a008 - Fix dataset package download

    Compare with previous version

  • Špela Dragan marked this merge request as ready

    marked this merge request as ready

  • merged

  • Marko Kuder mentioned in merge request !35 (merged)

    mentioned in merge request !35 (merged)

  • Marko Kuder mentioned in issue #11

    mentioned in issue #11

  • Please register or sign in to reply